Skip to content

Implemented hover styling for ItemTable #127

Closed
campb303 opened this issue Nov 25, 2020 · 3 comments · Fixed by #174
Closed

Implemented hover styling for ItemTable #127

campb303 opened this issue Nov 25, 2020 · 3 comments · Fixed by #174
Assignees
Labels
enhancement Request for a change to existing functionality

Comments

@campb303
Copy link
Collaborator

ItemTable does not currently highlight a row on hover. This should be implemented.

@campb303 campb303 added enhancement Request for a change to existing functionality frontend labels Nov 25, 2020
@campb303 campb303 added this to the v1 milestone Nov 25, 2020
@wrigh393
Copy link
Collaborator

Implementing highlighting for a row when it's being hovered over was implemented by adding the hover prop to the TableRow component in the TableBody component of the ItemTable. In addition to this, a CSS class was added to the row to help differentiate the hover styling from the styling that rows have due to being banded.

Default view for ItemTable:
image

Hover styling without custom CSS class:
image

Hover styling with custom CSS class:
image

The only problem that this fix presents is that the background color of the hover is similar to the color for a row when an item is selected. This is something that can be fixed easily and will likely change when we revisit the color theme as planned in #142

Hover row and selected row:
image

@campb303
Copy link
Collaborator Author

Is there an associated pull request for this logic?

Waiting for color scheme to be revisited.

@wrigh393 wrigh393 linked a pull request Feb 1, 2021 that will close this issue
@campb303
Copy link
Collaborator Author

campb303 commented Feb 5, 2021

Logic has been implemented. Color discussion should be had as part of the UI changes for v2. Closing.

@campb303 campb303 closed this as completed Feb 5, 2021
Sign in to join this conversation on GitHub.
Labels
enhancement Request for a change to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants