Skip to content

ItemViewAppBar displays unexpectedly #61

Closed
campb303 opened this issue Oct 4, 2020 · 9 comments
Closed

ItemViewAppBar displays unexpectedly #61

campb303 opened this issue Oct 4, 2020 · 9 comments
Assignees
Labels
bug An issue that results in webqueue2 breaking documentation Related to the writing documentation or the tools used to generate docs
Projects

Comments

@campb303
Copy link
Collaborator

campb303 commented Oct 4, 2020

After this commit, the ItemViewAppBar component displays unexpectedly in the documentation. This should be looked into to see if there's a better way to implement the fix for Safari or if the documentation example should have custom styling.

Example: ItemViewAppBar Unexpected Behavior
ItemViewAppBar Unexpected Behavior

Example: ItemTableAppBar Expected Behavior
ItemTableAppBar Expected Behavior

@campb303 campb303 added bug An issue that results in webqueue2 breaking documentation Related to the writing documentation or the tools used to generate docs frontend labels Oct 4, 2020
@campb303 campb303 added this to the v1 milestone Oct 4, 2020
@campb303
Copy link
Collaborator Author

Fixes for this have been reverted because of regression errors. This needs revisited.

@campb303
Copy link
Collaborator Author

This is related to #49

@campb303 campb303 assigned wrigh393 and unassigned celfreic Nov 25, 2020
@campb303
Copy link
Collaborator Author

This is still an issue though non-urgent.

@campb303
Copy link
Collaborator Author

campb303 commented Jan 4, 2021

This will need to be looked into again -- possible using an MUI drawer for the sidebar instead of CSS boxes.

@wrigh393
Copy link
Collaborator

wrigh393 commented Jan 4, 2021

The Drawer component from MaterialUI works in a similar fashion to the way that we are currently rendering the ItemView. Currently, we are rendering the ItemView in a Box component that renders the data based on the item that is selected from the ItemTable component. This same functionality should be achievable using the Drawer component. In our case, the persistent drawer example does a good job of how we could implement the component as it allows the drawer to be both opened and closed.

@campb303
Copy link
Collaborator Author

It seems that using the drawer will first require a fully responsive ItemTable to avoid horizontal scrolling.

@wrigh393
Copy link
Collaborator

wrigh393 commented Feb 8, 2021

In order to fix how ItemViewAppBar is displaying in the docs the width was changed from being inherited from the parent to 100% of the container that its in. The position prop was also changed from fixed to sticky:

Previous:

//This is the class that is applied to the component to change the width
appBarRoot: {width: "inherit"},

<AppBar position="fixed" color="secondary" elevation={2} classes={{root: classes.appBarRoot}}>

Current:

//The width was changed from "inherit" to "100%" 
//Leaving it as "inherit" causes the ItemView to be scrollable horizontally 
appBarRoot: {width: "100%"},

//The position prop was changed to "sticky" to get the component to render in the proper place in the docs
<AppBar position="sticky" color="secondary" elevation={2} classes={{root: classes.appBarRoot}}>

Previous docs view:
image
Current docs view
image

The next step is to address the extra space below the component in the doc view.

@wrigh393 wrigh393 linked a pull request Feb 10, 2021 that will close this issue
@campb303
Copy link
Collaborator Author

campb303 commented Mar 8, 2021

Waiting for #191 to be merged.

@campb303 campb303 added this to In progress in v1.0 Mar 8, 2021
@campb303
Copy link
Collaborator Author

When moving to Storybook this problem poofed.

v1.0 automation moved this from In progress to Done Mar 12, 2021
Sign in to join this conversation on GitHub.
Labels
bug An issue that results in webqueue2 breaking documentation Related to the writing documentation or the tools used to generate docs
Projects
No open projects
v1.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants