Skip to content

Implement sticky header in ItemTable #65

Closed
campb303 opened this issue Oct 12, 2020 · 5 comments
Closed

Implement sticky header in ItemTable #65

campb303 opened this issue Oct 12, 2020 · 5 comments
Assignees
Labels
enhancement Request for a change to existing functionality

Comments

@campb303
Copy link
Collaborator

To allow for a easier sense of place when scrolling through the ItemTable, a sticky header should be implemented. By default, the header should appear flat, being raised with a subtle shadow underneath to indicate that the user is no longer at the top of the table.

A fixed header is supposed in MUI as detailed here. #30 notes how useScrollTrigger can be used for conditional styling based on scrolling.

Example: Sticky header with shadow on scroll:
Sticky header with shadow on scroll
Image from Design better data tables by Andrew Coyle on Medium

@campb303 campb303 added enhancement Request for a change to existing functionality frontend labels Oct 12, 2020
@campb303 campb303 added this to the v1 milestone Oct 12, 2020
@campb303
Copy link
Collaborator Author

This was put on hold due to issues with parent CSS. The "sticky" header only works when no parents of the element have an overflow setting. This should be revisited after #49

@campb303 campb303 changed the title Implement sticky header with shadow Implement sticky header in ItemTable Nov 25, 2020
@campb303
Copy link
Collaborator Author

The filters of the ItemTable should be fixed on scroll making them always viewable.

@campb303
Copy link
Collaborator Author

This should be put on hold while a #164 is worked on.

@campb303 campb303 added this to To do in v1.0 Mar 8, 2021
@campb303 campb303 removed this from To do in v1.0 Mar 12, 2021
@campb303 campb303 modified the milestones: v1-proof-of-concept, v2-production-ready-read-only Mar 12, 2021
@campb303
Copy link
Collaborator Author

Moved to v2 milestone.

@campb303 campb303 removed the frontend label Mar 17, 2021
@campb303
Copy link
Collaborator Author

campb303 commented May 5, 2021

This was fixed in this commit.

@campb303 campb303 closed this as completed May 5, 2021
Sign in to join this conversation on GitHub.
Labels
enhancement Request for a change to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants