Skip to content

Implement visual to track currently open item in table #74

Closed
campb303 opened this issue Oct 21, 2020 · 2 comments
Closed

Implement visual to track currently open item in table #74

campb303 opened this issue Oct 21, 2020 · 2 comments
Assignees
Labels
enhancement Request for a change to existing functionality

Comments

@campb303
Copy link
Collaborator

Currently when an item is opened from the ItemTable, there is no visual connection between that item in the ItemTable and ItemView. It should be highlighted, perhaps with darkMode ? theme.palette.primary[50] : theme.palette.primary[900].

Example: Current Behavior
Screen Shot 2020-10-21 at 5 40 12 PM

Example: Desired Behavior (Light Mode)
Screen Shot 2020-10-21 at 5 39 52 PM

Example: Desired Behavior (Dark Mode)
Screen Shot 2020-10-21 at 5 41 30 PM

@campb303 campb303 assigned campb303 and wrigh393 and unassigned campb303 Oct 21, 2020
@campb303 campb303 added enhancement Request for a change to existing functionality frontend labels Oct 21, 2020
@campb303 campb303 added this to the v1 milestone Oct 21, 2020
@campb303
Copy link
Collaborator Author

campb303 commented Nov 3, 2020

This is related to #107

This also needs to be revisited as the color is difficult to see.

@wrigh393
Copy link
Collaborator

wrigh393 commented Nov 4, 2020

According to the MaterialUI TableRow API we should have had the ability to use the selected prop and override the selected CSS class but this did not work. In order to achieve the styling, we were seeking we are overriding the root CSS class and using a conditional operator to determine if an item is selected or not.

Previous behavior LightMode:
image

Previous behavior DarkMode:
image

Current behavior LightMode:
image

Current behavior DarkMode:
image

Sign in to join this conversation on GitHub.
Labels
enhancement Request for a change to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants