From a70813b6dbc02c50e4b956abcb5333c7e26d1fce Mon Sep 17 00:00:00 2001
From: jlpereira <pepelui@outlook.com>
Date: Mon, 21 Oct 2024 17:01:36 -0300
Subject: [PATCH 1/2] Moved files to PanelMap, sort shapes by type

---
 .../components/Panel/PanelKeys/PanelKeys.vue  |  2 +-
 .../components/Panel/PanelMap/PanelMap.vue    | 26 ++-------------
 .../Panel/PanelMap/constants/index.js         |  1 +
 .../Panel/PanelMap/constants/legend.js        | 22 +++++++++++++
 .../PanelMap}/store/useDistributionStore.js   | 33 +++++++++++++++----
 .../components/Panel/PanelMap/utils/index.js  |  3 ++
 .../Panel/PanelMap}/utils/isRankGroup.js      |  2 +-
 .../PanelMap}/utils/makeGeoJSONFeature.js     |  0
 .../PanelMap}/utils/removeDuplicateShapes.js  |  2 +-
 src/modules/otus/constants/typeOrder.js       |  6 ++++
 src/modules/otus/utils/index.js               |  3 --
 11 files changed, 64 insertions(+), 36 deletions(-)
 create mode 100644 src/modules/otus/components/Panel/PanelMap/constants/index.js
 create mode 100644 src/modules/otus/components/Panel/PanelMap/constants/legend.js
 rename src/modules/otus/{ => components/Panel/PanelMap}/store/useDistributionStore.js (73%)
 create mode 100644 src/modules/otus/components/Panel/PanelMap/utils/index.js
 rename src/modules/otus/{ => components/Panel/PanelMap}/utils/isRankGroup.js (62%)
 rename src/modules/otus/{ => components/Panel/PanelMap}/utils/makeGeoJSONFeature.js (100%)
 rename src/modules/otus/{ => components/Panel/PanelMap}/utils/removeDuplicateShapes.js (96%)

diff --git a/src/modules/otus/components/Panel/PanelKeys/PanelKeys.vue b/src/modules/otus/components/Panel/PanelKeys/PanelKeys.vue
index 519ad08..f80051a 100644
--- a/src/modules/otus/components/Panel/PanelKeys/PanelKeys.vue
+++ b/src/modules/otus/components/Panel/PanelKeys/PanelKeys.vue
@@ -39,7 +39,7 @@ import { onMounted, onBeforeUnmount, ref, computed } from 'vue'
 
 const props = defineProps({
   otuId: {
-    type: Object
+    type: Number
   }
 })
 
diff --git a/src/modules/otus/components/Panel/PanelMap/PanelMap.vue b/src/modules/otus/components/Panel/PanelMap/PanelMap.vue
index beeeb90..a6786aa 100644
--- a/src/modules/otus/components/Panel/PanelMap/PanelMap.vue
+++ b/src/modules/otus/components/Panel/PanelMap/PanelMap.vue
@@ -69,9 +69,10 @@
 
 <script setup>
 import { ref, onMounted, onBeforeUnmount } from 'vue'
-import { useDistributionStore } from '@/modules/otus/store/useDistributionStore.js'
+import { useDistributionStore } from './store/useDistributionStore.js'
 import { makeClusterIconFor } from './clusters/makeClusterIconFor'
 import { useGeojsonOptions } from './composables/useGeojsonOptions.js'
+import { LEGEND } from './constants'
 import MapPopup from './components/MapPopup.vue'
 import CachedMap from './components/CachedMap.vue'
 import OtuSearch from './components/Search/OtuSearch.vue'
@@ -107,29 +108,6 @@ const store = useDistributionStore()
 const popupElement = ref(null)
 const { popupItem, geojsonOptions } = useGeojsonOptions({ popupElement })
 
-const LEGEND = {
-  AssertedDistribution: {
-    label: 'Asserted distribution',
-    background: 'bg-map-asserted'
-  },
-  Georeference: {
-    label: 'Georeference',
-    background: 'bg-map-georeference'
-  },
-  TypeMaterial: {
-    label: 'Type material',
-    background: 'bg-map-type-material'
-  },
-  CollectionObject: {
-    label: 'Collection object',
-    background: 'bg-map-collection-object'
-  },
-  Aggregate: {
-    label: 'Aggregate (Asserted distribution & Georeference)',
-    background: 'bg-map-aggregate'
-  }
-}
-
 onMounted(() => {
   isLoading.value = true
 
diff --git a/src/modules/otus/components/Panel/PanelMap/constants/index.js b/src/modules/otus/components/Panel/PanelMap/constants/index.js
new file mode 100644
index 0000000..e8311d6
--- /dev/null
+++ b/src/modules/otus/components/Panel/PanelMap/constants/index.js
@@ -0,0 +1 @@
+export * from './legend'
diff --git a/src/modules/otus/components/Panel/PanelMap/constants/legend.js b/src/modules/otus/components/Panel/PanelMap/constants/legend.js
new file mode 100644
index 0000000..9107aa8
--- /dev/null
+++ b/src/modules/otus/components/Panel/PanelMap/constants/legend.js
@@ -0,0 +1,22 @@
+export const LEGEND = {
+  Aggregate: {
+    label: 'Aggregate (Asserted distribution & Georeference)',
+    background: 'bg-map-aggregate'
+  },
+  AssertedDistribution: {
+    label: 'Asserted distribution',
+    background: 'bg-map-asserted'
+  },
+  Georeference: {
+    label: 'Georeference',
+    background: 'bg-map-georeference'
+  },
+  CollectionObject: {
+    label: 'Collection object',
+    background: 'bg-map-collection-object'
+  },
+  TypeMaterial: {
+    label: 'Type material',
+    background: 'bg-map-type-material'
+  }
+}
diff --git a/src/modules/otus/store/useDistributionStore.js b/src/modules/otus/components/Panel/PanelMap/store/useDistributionStore.js
similarity index 73%
rename from src/modules/otus/store/useDistributionStore.js
rename to src/modules/otus/components/Panel/PanelMap/store/useDistributionStore.js
index 263ba33..f4e57ee 100644
--- a/src/modules/otus/store/useDistributionStore.js
+++ b/src/modules/otus/components/Panel/PanelMap/store/useDistributionStore.js
@@ -1,12 +1,31 @@
-import TaxonWorks from '../services/TaxonWorks'
+import TaxonWorks from '../../../../services/TaxonWorks'
 import { defineStore } from 'pinia'
-import { useOtuPageRequest } from '../helpers/useOtuPageRequest'
-import { RESPONSE_ERROR } from '../constants'
+import { useOtuPageRequest } from '../../../../helpers/useOtuPageRequest'
+import { RESPONSE_ERROR } from '../../../../constants'
 import {
-  isRankGrpup,
+  isRankGroup,
   removeDuplicateShapes,
   makeGeoJSONFeature
 } from '../utils'
+import { LEGEND } from '../constants'
+
+function sortFeaturesByType(arr, reference) {
+  const referenceMap = new Map()
+
+  reference.forEach((item, index) => {
+    referenceMap.set(item, index)
+  })
+
+  return arr.toSorted((a, b) => {
+    const indexA = referenceMap.has(a.properties.base.type)
+      ? referenceMap.get(a.properties.base.type)
+      : Infinity
+    const indexB = referenceMap.has(b.properties.base.type)
+      ? referenceMap.get(b.properties.base.type)
+      : Infinity
+    return indexA - indexB
+  })
+}
 
 export const useDistributionStore = defineStore('distributionStore', {
   state: () => {
@@ -60,7 +79,7 @@ export const useDistributionStore = defineStore('distributionStore', {
 
     async loadDistribution({ otuId, rankString }) {
       const isSpeciesGroup =
-        rankString && isRankGrpup('SpeciesGroup', rankString)
+        rankString && isRankGroup('SpeciesGroup', rankString)
 
       this.controller = new AbortController()
 
@@ -75,7 +94,9 @@ export const useDistributionStore = defineStore('distributionStore', {
               this.distribution.geojson = null
               this.distribution.errorMessage = data.message
             } else {
-              const { features, shapeTypes } = removeDuplicateShapes(data)
+              const { features, shapeTypes } = removeDuplicateShapes(
+                sortFeaturesByType(data.features, Object.keys(LEGEND))
+              )
 
               this.distribution.currentShapeTypes = shapeTypes
               this.distribution.geojson = {
diff --git a/src/modules/otus/components/Panel/PanelMap/utils/index.js b/src/modules/otus/components/Panel/PanelMap/utils/index.js
new file mode 100644
index 0000000..1094c15
--- /dev/null
+++ b/src/modules/otus/components/Panel/PanelMap/utils/index.js
@@ -0,0 +1,3 @@
+export * from './isRankGroup'
+export * from './makeGeoJSONFeature'
+export * from './removeDuplicateShapes'
diff --git a/src/modules/otus/utils/isRankGroup.js b/src/modules/otus/components/Panel/PanelMap/utils/isRankGroup.js
similarity index 62%
rename from src/modules/otus/utils/isRankGroup.js
rename to src/modules/otus/components/Panel/PanelMap/utils/isRankGroup.js
index 494b968..55e244c 100644
--- a/src/modules/otus/utils/isRankGroup.js
+++ b/src/modules/otus/components/Panel/PanelMap/utils/isRankGroup.js
@@ -1,4 +1,4 @@
-export function isRankGrpup(compareRank, rank) {
+export function isRankGroup(compareRank, rank) {
   const rankGroup = rank.split('::').at(2)
 
   return rankGroup === compareRank
diff --git a/src/modules/otus/utils/makeGeoJSONFeature.js b/src/modules/otus/components/Panel/PanelMap/utils/makeGeoJSONFeature.js
similarity index 100%
rename from src/modules/otus/utils/makeGeoJSONFeature.js
rename to src/modules/otus/components/Panel/PanelMap/utils/makeGeoJSONFeature.js
diff --git a/src/modules/otus/utils/removeDuplicateShapes.js b/src/modules/otus/components/Panel/PanelMap/utils/removeDuplicateShapes.js
similarity index 96%
rename from src/modules/otus/utils/removeDuplicateShapes.js
rename to src/modules/otus/components/Panel/PanelMap/utils/removeDuplicateShapes.js
index c90bd8f..5f0a197 100644
--- a/src/modules/otus/utils/removeDuplicateShapes.js
+++ b/src/modules/otus/components/Panel/PanelMap/utils/removeDuplicateShapes.js
@@ -2,7 +2,7 @@ export function removeDuplicateShapes(data) {
   const features = []
   const shapeTypes = []
 
-  data.features.forEach((feature) => {
+  data.forEach((feature) => {
     const shapeId = feature.properties.shape.id
     const shapeType = feature.properties.shape.type
 
diff --git a/src/modules/otus/constants/typeOrder.js b/src/modules/otus/constants/typeOrder.js
index 3fe89d1..7f8a423 100644
--- a/src/modules/otus/constants/typeOrder.js
+++ b/src/modules/otus/constants/typeOrder.js
@@ -8,3 +8,9 @@ export const SPECIMEN_TYPES = [
   'paratype',
   'paratypes'
 ]
+
+export const FEATURE_OBJECT_TYPES = [
+  'AssertedDistribution',
+  'CollectionObject',
+  'TypeMaterial'
+]
diff --git a/src/modules/otus/utils/index.js b/src/modules/otus/utils/index.js
index 1a97887..7eb39a5 100644
--- a/src/modules/otus/utils/index.js
+++ b/src/modules/otus/utils/index.js
@@ -1,4 +1 @@
 export * from './isAvailableForRank'
-export * from './isRankGroup'
-export * from './makeGeoJSONFeature'
-export * from './removeDuplicateShapes'

From fcadddc6329f502d40ffd9b51325eb37511fcea4 Mon Sep 17 00:00:00 2001
From: jlpereira <pepelui@outlook.com>
Date: Mon, 21 Oct 2024 17:03:11 -0300
Subject: [PATCH 2/2] Remove unused const

---
 src/modules/otus/constants/typeOrder.js | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/modules/otus/constants/typeOrder.js b/src/modules/otus/constants/typeOrder.js
index 7f8a423..3fe89d1 100644
--- a/src/modules/otus/constants/typeOrder.js
+++ b/src/modules/otus/constants/typeOrder.js
@@ -8,9 +8,3 @@ export const SPECIMEN_TYPES = [
   'paratype',
   'paratypes'
 ]
-
-export const FEATURE_OBJECT_TYPES = [
-  'AssertedDistribution',
-  'CollectionObject',
-  'TypeMaterial'
-]