revert(skip-unchanged): drop in-engine incremental Phase 1a #6
+0
−341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts 5df25c6. The in-engine incremental approach (skip-unchanged Phase 1a + the PR #4 RFC) is superseded by Fortress-native incremental/ versioned backup, so the skip_unchanged path and its tests are removed rather than carried as dead, default-off code. No change to the default daily flow (skip_unchanged was default false). Removes archive.py's skippable_prior_log / source_matches_log helpers and the skip-decision block, plus tests/test_skip_unchanged.py. Remaining suite: 37 tests green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 26, 2026
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the skip-unchanged feature (#5, commit 5df25c6).
Why: the in-engine incremental approach (skip-unchanged Phase 1a + the #4 RFC) is superseded by Fortress-native incremental/versioned backup. Rather than carry
skip_unchangedas dead, default-off code, this removes it.What:
archive.pyskippable_prior_log/source_matches_log+ the skip-decision block (−134)tests/test_skip_unchanged.py(−207)skip_unchangeddefaulted tofalse)Verification: remaining suite green — 37 tests pass.
Companion cleanup: #4 (RFC) closed as superseded; stale
feat/skip-unchangedbranch deleted.🤖 Generated with Claude Code