Skip to content

Commit

Permalink
Don't define search path for includes and libs
Browse files Browse the repository at this point in the history
Compilers' and linkers' default search paths are fine on modern Linux. The
custom search path was wrong on 32bit platforms anyway. When library_dirs is
defined, distutils also adds rpath to the shared library. An rpath
should not be added by default.

I only commented out the configuration stanzes to keep them as example.

Closes: https://github.com/python-ldap/python-ldap/issues/30
Signed-off-by: Christian Heimes <cheimes@redhat.com>
  • Loading branch information
Christian Heimes committed Nov 28, 2017
1 parent e5cd30c commit 703d322
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@
# for wrapping OpenLDAP 2 libs
[_ldap]

# Define extra include and library dirs if needed
library_dirs = /usr/lib /usr/lib64 /usr/local/lib /usr/local/lib64
include_dirs = /usr/include /usr/include/sasl /usr/local/include /usr/local/include/sasl
# Define extra include and library dirs if needed. distutils adds non
# standard library_dirs as rpath.
# library_dirs = /usr/lib /usr/lib64 /usr/local/lib /usr/local/lib64
# include_dirs = /usr/include /usr/include/sasl /usr/local/include /usr/local/include/sasl

# These defines needs OpenLDAP built with
# ./configure --with-cyrus-sasl --with-tls
Expand Down

0 comments on commit 703d322

Please sign in to comment.