Feature rewrite parser in formal grammar #41

benne238 · 2021-07-12T16:34:58Z

No description provided.

…e to format_date_string

…initial message content

…or the "to" and "cc" keys

… attributes

…ction

…ions function" This reverts commit e7e7687.

…ctions by the datetime key

… to indicate malformed header information in the reply from user section

… by a newline

…ctly in the reply_from_user section

… item.py module

…essage when the parser encounters a malformed delimiter

…ade the skipTo look for delimiters at the begining of the line

…e the skipTo look for delimiters at the begining of the line

…r and made the skipTo look for delimiters at the begining of the line

…at the start of a given line in the status, edit, and reply-to-user rules

…if a Date header is not found in a reply from user section

…e formatted in a particular way

…tus rules

campb303

Overall fine. Beautifully simple functions in the Item class. Some documentation changes needed. Also need to recreate __init__.py in the top level package.

src/webqueue2api/parser/item.py

src/webqueue2api/parser/parser.py

webqueue2_api/__init__.py

benne238 added 30 commits June 28, 2021 12:45

Remove old ECNQueue module

e634be1

Add pyparsing to requirements

2648c8e

Add ParseError to parser module

425b41a

Move Item.__get_formatted_date to webqueue2api.parser.utils and renam…

dc11658

…e to format_date_string

Refactor to use new format_date_string function

12407b0

replaced old parser and imported new pyparsing parser in the item class

7ee915f

Fixed bug where the end of the string was not matched

5738191

created function to append the initial message headers to the parsed …

c7e0d0a

…initial message content

modifed __add_initial_message_headers to output the expected format f…

0f69c18

…or the "to" and "cc" keys

Moved the content attribute in item to be defined after all the other…

42bb135

… attributes

add_intitial_message_headers function call from the parseSections fun…

e7e7687

…ction

Revert "add_intitial_message_headers function call from the parseSect…

b701cda

…ions function" This reverts commit e7e7687.

return initial message section with appropriate headers

3951832

formatted function names to camel case

b9d4945

add function call to __get_sorted_sections to sort the parsed item se…

de2dd76

…ctions by the datetime key

add assignment parsing to item.py

4dfb974

modified repy_from_user_end_delimiter to not include an ending newline

d858c0c

added a condition that checks for an ending reply from user delimiter…

56798fb

… to indicate malformed header information in the reply from user section

fixed error message for header information not seperated from content…

f61860e

… by a newline

Add logic to return an error_parse if a header is not formatted corre…

8289ae7

…ctly in the reply_from_user section

moved the email.policy configuration from the parser.py module to the…

f5e5619

… item.py module

modified action end delimiter and modified the expected value error m…

595b1be

…essage when the parser encounters a malformed delimiter

modified the status rule to expect only a single line delimiter and m…

66b65d7

…ade the skipTo look for delimiters at the begining of the line

modified the edit rule to expect only a single line delimiter and mad…

5fbc373

…e the skipTo look for delimiters at the begining of the line

modified the reply to user rule to expect only a single line delimite…

a3fafba

…r and made the skipTo look for delimiters at the begining of the line

added pp.LineStart() to explicity look for reply_from_user delimiter …

1d0358c

…at the start of a given line in the status, edit, and reply-to-user rules

Added logic to raise a parser error with the appropriate information …

f7114c2

…if a Date header is not found in a reply from user section

Made expected message relevent: the datetime string doesn't need to b…

a84d8e7

…e formatted in a particular way

added docstring to __get_assignments

5383f8f

added docstring to __parse_sections

23abdf3

Made initial message rule more similar to the edit, reply-to, and sta…

c9d04e5

…tus rules

campb303 requested changes Aug 2, 2021

View reviewed changes

campb303 added 4 commits August 2, 2021 17:41

Remove unused datetime import

84cb7b4

Correct __add_initial_message_headers doc block

80cc1cb

Cleanup __get_sorted_sections

5e07895

Rename reply to user delimiter

206ed36

campb303 merged commit 5c10453 into staging Aug 2, 2021

campb303 deleted the feature-rewrite-parser-in-formal-grammar branch August 2, 2021 21:56

campb303 mentioned this pull request Aug 2, 2021

Rewrite parser in a formal grammer #25

Closed

Feature rewrite parser in formal grammar #41

Feature rewrite parser in formal grammar #41

benne238 commented Jul 12, 2021

campb303 left a comment

Feature rewrite parser in formal grammar #41

Feature rewrite parser in formal grammar #41

Conversation

benne238 commented Jul 12, 2021

campb303 left a comment

Choose a reason for hiding this comment