-
Notifications
You must be signed in to change notification settings - Fork 0
Feature implement config file override for webqueue2api configs #46
Merged
campb303
merged 8 commits into
staging
from
feature-implement-config-file-override-for-webqueue2api-configs
Aug 2, 2021
Merged
Feature implement config file override for webqueue2api configs #46
campb303
merged 8 commits into
staging
from
feature-implement-config-file-override-for-webqueue2api-configs
Aug 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the root of the webqueue2api package directory and read the configurations from that file if so
…ains a queue_directory in the parser section
…tion file under the parser section
… config file under the api section
… the config file under the api section
campb303
commented
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial code here. Needs to be expanded.
src/webqueue2api/__init__.py
Outdated
|
||
config_parser_object = configparser.ConfigParser() | ||
config_file_location = path.joinpath(path(sys.executable).parent.parent.parent, "webqueue2api_config") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename config_file_location
to config_file_path
and add file extension.
src/webqueue2api/__init__.py
Outdated
import webqueue2api.api | ||
|
||
config_parser_object = configparser.ConfigParser() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename config_parser_object
to config_parser
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.