Skip to content

Commit

Permalink
Fix issues with subprocess in Python <= 3.6.9
Browse files Browse the repository at this point in the history
  • Loading branch information
Justin Campbell committed Sep 28, 2020
1 parent d9c2e6b commit 29a8c71
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion utils/venv-manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def run_logged_subprocess(command: Union[str, list], timeout: int = 10, shell: b
"""
logger.debug(f"Entering subprocess for '{command}'")
with subprocess.Popen(command,\
stderr=subprocess.STDOUT, stdout=subprocess.PIPE, shell=shell, text=True)\
stderr=subprocess.STDOUT, stdout=subprocess.PIPE, shell=shell, universal_newlines=True)\
as logged_shell_process:

subprocess_log_prefix = f"(PID: {logged_shell_process.pid})"
Expand Down

0 comments on commit 29a8c71

Please sign in to comment.