Skip to content

Commit

Permalink
Simplify userName and userEmail assignment in Item class
Browse files Browse the repository at this point in the history
  • Loading branch information
Justin Campbell committed Jul 27, 2020
1 parent b0b85e6 commit bbf89fc
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions api/ECNQueue.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ def __init__(self, queue: str, number: int) -> None:
self.headers = self.__parseHeaders()
self.content = self.__getContent()
self.isLocked = self.__isLocked()
self.userEmail = self.__getUserEmail()
self.userName = self.__getUserName()
self.userEmail = self.__parseFromData(data="userEmail")
self.userName = self.__parseFromData(data="userName")
self.userAlias = self.__getUserAlias()
self.assignedTo = self.__getAssignedTo()
self.subject = self.__getMostRecentHeaderByType("Subject")["content"]
Expand Down Expand Up @@ -235,12 +235,6 @@ def __parseFromData(self, data: str) -> str:
if data == "userName": return userName
elif data == "userEmail": return userEmail
else: raise ValueError("data='" + str(data) + "' is not a valid option. data must be \"userName\" or \"userEmail\".")

def __getUserName(self, data="userName") -> str:
return self.__parseFromData(data)

def __getUserEmail(self, data="userEmail") -> str:
return self.__parseFromData(data)

def __getUserAlias(self) -> str:
"""Returns user's Career Account alias if present.
Expand Down

0 comments on commit bbf89fc

Please sign in to comment.