-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Cannot merge at this time. Breaks on aae55 in the live queue. A copy of aae55 is below:
|
Empty ContentThe parser attempts to find the ending line and starting line of content within and item, storing the line numbers in respective variables: if contentEnd <= contentStart:
blankInitialMessage = self.__initialMessageParsing([""])
sections.append(blankInitialMessage)
return sections This snipet will call the |
commit d9942b9 Author: benne238 <benne238@purdue.edu> Date: Wed Jan 27 21:05:25 2021 -0500 removal of debugging lines commit 02ab227 Author: benne238 <benne238@purdue.edu> Date: Wed Jan 27 21:04:33 2021 -0500 fix for accounting for empty content in messages commit 610bc86 Author: benne238 <benne238@purdue.edu> Date: Tue Jan 12 15:23:52 2021 -0500 removal of queueDirectory testing code commit 30d9cfe Author: benne238 <benne238@purdue.edu> Date: Mon Jan 11 14:30:01 2021 -0500 implementation of blank content handling commit 2bd362c Author: Justin Campbell <campb303@purdue.edu> Date: Wed Dec 30 15:13:54 2020 -0500 Update Python requirements to fix Flask_JWT_Extended and PyJWT conflict commit 38445fe Merge: 0fd6f0a c20b9b8 Author: Campbell, Justin <campb303@purdue.edu> Date: Tue Dec 15 21:55:33 2020 -0500 Merge pull request #154 from ECN/enhancement-persistent-filters-and-sorting Enhancement persistent filters and sorting commit c20b9b8 Author: Justin Campbell <campb303@purdue.edu> Date: Tue Dec 15 21:54:39 2020 -0500 Minor formatting commit 2cccad2 Author: Tyler Jordan Wright <wrigh393@w2vm1.ecn.purdue.edu> Date: Fri Dec 11 13:09:17 2020 -0500 Set autoResetFilters to false in order to stop filters from resetting on data change. commit d842e2c Author: Tyler Jordan Wright <wrigh393@w2vm1.ecn.purdue.edu> Date: Wed Dec 9 11:08:19 2020 -0500 disabled autoResetSortBy to allow for sorting to persist when data changes. commit 0fd6f0a Author: Justin Campbell <campb303@w2vm4.ecn.purdue.edu> Date: Thu Dec 3 20:13:58 2020 -0500 Update UI Snapshot
Bugfix queues that won't load
This reverts commit 7535510.
…ebqueue2 into Bugfix-Webmaster-Queue
TestingThe Bugfix-Webmaster-Queue branch was locally merged into staging and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments about explicit exception handling.
api/ECNQueue.py
Outdated
try: | ||
emailUser, emailDomain = self.userEmail.split("@") | ||
|
||
except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more explicit here. What error are you anticipating? Catch it by name. For example:
# Catching a divide by zero error.
try:
num = 1 / 0
catch DivideByZeroError as e:
print("Cannot divide by 0. Try again.")
No description provided.