Skip to content
Jump to bottom

Enhancement ItemTable Visual Improvements #155

Merged
merged 12 commits into from
Mar 13, 2021
Merged

Enhancement ItemTable Visual Improvements #155

merged 12 commits into from
Mar 13, 2021
+177 −55

Conversation

wrigh393
Copy link
Collaborator

Closes #146

@campb303
Copy link
Collaborator

The ItemTable component has grown in complexity and is becoming hard to manage. There a re few things that should happen to make this better:

  • Move the filtering function to its own component
  • Remove the grid usage in the header if possible
  • Address the border gap for the columns of the table body
Screen Shot 2020-12-16 at 4 55 18 PM

@campb303 campb303 mentioned this pull request Jan 5, 2021
Closed
@campb303 campb303 linked an issue Jan 5, 2021 that may be closed by this pull request
Misc ItemTable visual improvements #146
Closed
@campb303 campb303 added enhancement Request for a change to existing functionality frontend high-priority Needs immediate extra focus labels Jan 5, 2021
@campb303 campb303 self-assigned this Jan 5, 2021
campb303
campb303 requested changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@campb303 campb303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The ItemTableSortButtnons need to be refactored. See review comments about this.
  • PropTypes and defaults need to be added.
  • Component docs need to be created. None are present.

src/components/ItemTableSortButtons.js/ItemTableSortButtons.js Outdated Show resolved Hide resolved
src/components/ItemTableSortButtons.js/ItemTableSortButtons.js Outdated Show resolved Hide resolved
@wrigh393
Refactored code to reduce number of props for ItemTableSortButtons co…
2595643 
…mponent; added prop types to ItemTableSortButtons; renamed folder to use same naming convention
@wrigh393
Fixed merge conflicts
10de4bd
@campb303 campb303 merged commit 21858cd into staging Mar 13, 2021
@campb303 campb303 deleted the enhancement-itemtable-visual-improvements branch March 14, 2021 21:16
@wrigh393 wrigh393 mentioned this pull request Jun 25, 2021
Closed
Sign in to join this conversation on GitHub.
Reviewers

@campb303 campb303 campb303 approved these changes

Assignees

@campb303 campb303

Labels
enhancement Request for a change to existing functionality high-priority Needs immediate extra focus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misc ItemTable visual improvements
2 participants
@wrigh393 @campb303