Skip to content
Jump to bottom

Changed Autocomplete loading prop value to be same as loading variable value; Changed noOptionsText to be more specific #218

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Changed Autocomplete loading prop value to be same as loading variable value; Changed noOptionsText to be more specific #218

merged 2 commits into from
Jul 8, 2021
+7 −4

Conversation

wrigh393
Copy link
Collaborator

Closes #190

@wrigh393
Changed Autocomplete loading prop value to be same as loading variabl…
9d7131f 
…e value; Changed noOptions text to be more specific
@wrigh393 wrigh393 added bug An issue that results in webqueue2 breaking quickfix Immediately actionable and should be fast labels Jun 29, 2021
@wrigh393 wrigh393 requested a review from campb303 June 29, 2021 20:58
@wrigh393 wrigh393 linked an issue Jun 29, 2021 that may be closed by this pull request
QueueSelector shows loading message when item not found instead of not found message #190
Closed
@campb303
Copy link
Collaborator

campb303 commented Jul 1, 2021

Please change the noOptionsText from "Queue does not exist" to "Queue <search_value> not found" where <search_value> is the string being searched for.

e.g. If I search for "boop" the noOptionsText should be "Queue boop not found"

@campb303 campb303 merged commit 09776be into staging Jul 8, 2021
@campb303 campb303 deleted the bugfix-queueselector-loading-when-queue-doesnt-exist branch July 8, 2021 21:20
Sign in to join this conversation on GitHub.
Reviewers

@campb303 campb303 Awaiting requested review from campb303

Assignees
No one assigned
Labels
bug An issue that results in webqueue2 breaking quickfix Immediately actionable and should be fast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QueueSelector shows loading message when item not found instead of not found message
2 participants
@wrigh393 @campb303