-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
…ber of items filtered from the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues with the code at this point. Per #152 (comment) this architecture will e replaced with a new approach.
@@ -98,6 +98,11 @@ export default function ItemTable({ data, rowCanBeSelected, loading }) { | |||
); | |||
const { getTableProps, getTableBodyProps, headerGroups, rows, prepareRow, } = tableInstance; | |||
|
|||
//Sets filteredItems length when items are filtered from the table/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add space between comment marker and comment content.
- //Sets...
+ // Sets...
setValue={setSelectedQueues} | ||
/> | ||
</Box> | ||
<ItemCounter filteredItems={filteredItems} totalItems={items.length} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be better to use the autocalculated value from the react-table instance inside ItemTable than the derived value from here to insure the count is kept in sync with what the UI reflects.
Closing to be replaced with another branch. |
Closes #152