Change sort button to display both sorting directions at the same time. #88

wrigh393 · 2020-10-23T19:38:55Z

No description provided.

campb303 · 2020-10-27T22:07:12Z

As this is implemented now, no matter which arrow I click on, the top arrow is selected first, then the bottom, then they are disabled. This functionality should instead be two independent toggles that behave like this:

When no sorting is active, a click on an arrow should sort the table based on the direction of that arrow.
When one sort is active, a click on the opposite arrow should deactivate the current sort and activate the opposite sort. The UI should change accordingly.
When one sort is active, a clock on the corresponding sort should deactivate the currentsort. The UI should change accordingly.

campb303

See my comment in the conversation view.

wrigh393 · 2020-10-28T19:07:00Z

By implementing an onClick event to the <IconButton> components we were able to get the buttons to allow users to sort the table based on the direction of the icon they selected. This was necessary because react-table does not have the ability to set sort direction built into the getSortByToggle() props.

…cted

campb303 · 2020-10-30T16:18:33Z

src/components/ItemTable/ItemTable.js

@@ -19,6 +20,11 @@ export default function ItemTable({ data, onRowClick }) {
        inactiveSortIcon: {
            opacity: 0.2,
        },
+        selectedItem: {


Is this for row selection?

Change srot button to display both sorting directions at the same time.

a7720db

campb303 requested changes Oct 27, 2020

View reviewed changes

Tyler Jordan Wright and others added 6 commits October 30, 2020 10:34

Fixed sort toggle buttons to allow sort by direction of the icon sele…

190c75f

…cted

Merge branch 'staging' into Enhancement-ItemTable-sortButton

c8782a4

removed row selection code from branch

9be5a9e

Removed row selection code and merge changes from remote

3b4ef18

Cleanup

496196e

Fixed row click

e3eb945

campb303 approved these changes Oct 30, 2020

View reviewed changes

wrigh393 merged commit da2592d into staging Oct 30, 2020

wrigh393 deleted the Enhancement-ItemTable-sortButton branch October 30, 2020 16:54

Change sort button to display both sorting directions at the same time. #88

Change sort button to display both sorting directions at the same time. #88

wrigh393 commented Oct 23, 2020

campb303 commented Oct 27, 2020

campb303 left a comment

wrigh393 commented Oct 28, 2020

campb303 Oct 30, 2020

Change sort button to display both sorting directions at the same time. #88

Change sort button to display both sorting directions at the same time. #88

Conversation

wrigh393 commented Oct 23, 2020

campb303 commented Oct 27, 2020

campb303 left a comment

Choose a reason for hiding this comment

wrigh393 commented Oct 28, 2020

campb303 Oct 30, 2020

Choose a reason for hiding this comment