Evan #14
Merged
Evan #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seford
reviewed
Mar 28, 2021
app/src/main/java/com/sf/stormwaterutilityandroid/DryWeatherScreening.java
Show resolved
Hide resolved
seford
suggested changes
Mar 28, 2021
app/src/main/java/com/sf/stormwaterutilityandroid/WaterWay/General.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sf/stormwaterutilityandroid/DryWeatherScreening.java
Outdated
Show resolved
Hide resolved
seford
suggested changes
Mar 28, 2021
| @@ -44,56 +44,56 @@ | |||
| boolean needMaintenance = false; | |||
| boolean screenOK = false; | |||
|
|
|||
There was a problem hiding this comment.
None of these classes should be separate. The form parts should go in the setup methods in the Waterway form frgment. Please read through the code and run it, so you can understand what it is doing. It is very trivial to understand it once you run it and look at the code.
seford
approved these changes
Apr 1, 2021
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not final push but would like you to review some of the changes before i push everything