Edit unit experiment templates in place; add °C/min, h and degree units #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library's "Run / Edit" opened the template in the create form, so any edit saved a copy. A new Edit button (owner or admin, matching the backend rule) opens /experiment/new?edit_type=<id>, which saves through the existing PATCH endpoint as a new version with an optional change summary. The equipment is locked, saving waits until the template has loaded, author fields are carried over, and equipment parameters added since the template was saved appear as "not used". The old button is renamed "Run / Copy". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Furnace heating and cooling rates had to be registered as "N/A" because the unit list had no °C/min; hours and degrees (XRD 2-theta and step size) were also missing. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/experiment/new?edit_type=<id>, and saving goes through the existingPATCH /equipment/experiment-type/{id}as a new version, with an optional change summary. Before this, "Run / Edit" always saved a copy; that button is now "Run / Copy".h,°C/minand°are added to the equipment registration list. Furnace heating and cooling rates were stuck on "N/A", and XRD 2θ and step size had no unit.Why
The MAX legacy XRD experiment needs new inputs (Composition, Researcher) and XRD outputs, but templates couldn't be edited from the UI. Tyriq also needs °C/min for the tube furnaces.
Testing
tsc --noEmit,eslintandnext buildpass.Deploy
Front-end only: a web image build plus
kubectl set imageondt-web. No migration, no API change.🤖 Generated with Claude Code