Refresh unit experiment inputs from the equipment when editing #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A template keeps its own copy of each equipment input, so later equipment edits (new units, renamed inputs) never reached it, and the edit page shows that copy read-only. In edit mode, take unit, type and settability from the current equipment registration, and mark inputs the equipment no longer has as 'not on equipment' so the owner can set them to Not used. Reported by Tyriq Turner (MAX Synthesis WL-1/WL-2: rates stuck at N/A, Max Temperature shown next to Temperature). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ppc5pC4MsLsz5apZ9qWTmq
- Use the equipment's unit as is, including an empty one. - Show a tool-controlled Variable input as Fixed, as it is saved. - Flag template inputs even when the equipment now has none, but only once its registration loaded. - Before saving an edit, check each used input's default and bounds against its (possibly new) type. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ppc5pC4MsLsz5apZ9qWTmq
Bounds of an integer input may be fractional, as the run validators allow; require only that a whole number lies between them. Date/time defaults are checked as ISO 8601 with real calendar and clock values, since template saves are not validated by the API. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ppc5pC4MsLsz5apZ9qWTmq
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ppc5pC4MsLsz5apZ9qWTmq
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates keep their own copy of each equipment input, so later equipment edits (fixed units, renamed inputs) never reached them, and the edit page shows that copy read-only. Reported by Tyriq Turner: MAX Synthesis WL-1/WL-2 show Heating/Cooling Rate as N/A while the furnace says °C/min, and 'Max Temperature' next to the furnace's renamed 'Temperature'.
When a template is edited:
Web-only change (
web/app/experiment/new/page.tsx).tscand ESLint clean; scenario checks run against the WL templates' real data. Codex review: APPROVE after 4 rounds.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ppc5pC4MsLsz5apZ9qWTmq