Highlight toggle #24
Merged
Highlight toggle #24
+26
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the student and main userscripts had incompatible highlighting methods, e.g. for !! and ~~ highlighting. The main userscript would highlight the whole block, preserving only the text within the delimiters, while the student userscript would highlight only the text, but preserve all of the text within the block.
These edits add a toggle within the userscript settings menu to switch between these two highlighting methods similar to how the link behavior is handled. It defaults to the previous block highlighting scheme, but can be switched to the text behavior with a simple toggle of the radio buttons, saving that config to local storage with the rest of the configuration options.