Christian timetagger refactoring #6
Merged
+3,462
−1,107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change is that the timetagger doesn't ever stop the measurement. It just gets the most recent data. So there is no down time between collections.
The scan is working. But you cannot take more than one scan in a row. I am working on getting confident that there is no lost data.
Data is now packaged in TerascanLogicData I also added some more signals to connect logic and gui. This code is untested.
This is not carefully tested.
default scan tyep and rate still not working Save data is not working
I added a function written by ChatGPT. I have not tested it yet.
I changed the photon counts window to work with the new swabian internal logic. I also added a number of counts that updates with the plot.
To keep logic and laser from having copied enums, I put the enum classes as a subclass in solstis laser. We still need to get ried of the redundant ocde in get_scan_type etc., and we also need to get rid of the redundant code where solsits_funcs also has the enum.
I added a file to scan many times using terascan_logic. I also changed save_data so you can specify a path.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several improvements to the timetagger handling and Terascan logic to improve stability and enable persistent automated scans:
Timetagger Queue Redesign
The timetagger no longer drops counts. It now uses a continuously running queue, which buffers incoming events. The GUI scrapes this queue whenever it updates, decoupling GUI refresh rate from timetagger data acquisition. This implementation has been tested by Arya over a two-week period and appears stable.
Persistent Scan Logic in
terascan_logicThe
terascan_logicmodule now supports persistent scanning. It continually checks whether a scan should be running and ensures the scan resumes as needed until completion. The module remains locked during scanning and only unlocks once it is confident the scan has finished successfully.Separation of Logic and GUI in Terascan
Refactored
terascan_logicandterascan_logic_guito allow automated scans to be triggered purely throughterascan_logic, without GUI interaction. This avoids crashes when modifying scan behavior from code and makes the logic module safe for headless operation.